Possible fix for #5470 - json_decode() (#5511)

Browse Source

* Possible fix for #5470:
- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:

  $object['foo'] = 123;
  $array->foo = 123;

- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
  E_NOTICE
- added some empty lines for better readability

* Rewrite:
- mixture of object/array was here, causing under newer PHP versions some E_NOTICE
- this has been now finally fixed by converting any `object` type to an
  associative `array`
- also changed `is_object()` to `is_array()`

pull/5514/head

Roland Häder 2018-07-28 07:35:27 +02:00 committed by Hypolite Petovan

parent 4a22710b3b

commit c30ac30f29

1 changed files with 301 additions and 250 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

551

src/Protocol/PortableContact.php

View File

File diff suppressed because it is too large Load Diff