From 84c8c4f0029032f31becd6ec8d9032da4be88462 Mon Sep 17 00:00:00 2001 From: Michael Vogel Date: Thu, 22 Nov 2012 02:00:31 +0100 Subject: [PATCH 1/6] fbpost: Enable posting to pages --- fbpost/fbpost.php | 74 +++++++++++++++++++++++++++++++++-------- statusnet/statusnet.php | 20 ++++++++--- 2 files changed, 75 insertions(+), 19 deletions(-) diff --git a/fbpost/fbpost.php b/fbpost/fbpost.php index 1116971d..01311320 100644 --- a/fbpost/fbpost.php +++ b/fbpost/fbpost.php @@ -140,11 +140,18 @@ function fbpost_post(&$a) { $value = ((x($_POST,'post_by_default')) ? intval($_POST['post_by_default']) : 0); set_pconfig($uid,'facebook','post_by_default', $value); + $value = ((x($_POST,'suppress_view_on_friendica')) ? intval($_POST['suppress_view_on_friendica']) : 0); + set_pconfig($uid,'facebook','suppress_view_on_friendica', $value); + + $value = ((x($_POST,'post_to_page')) ? $_POST['post_to_page'] : "0-0"); + $values = explode("-", $value); + set_pconfig($uid,'facebook','post_to_page', $values[0]); + set_pconfig($uid,'facebook','page_access_token', $values[1]); info( t('Settings updated.') . EOL); - } + } - return; + return; } // Facebook settings form @@ -202,7 +209,7 @@ function fbpost_content(&$a) { $o .= '
'; $o .= '' . t('Install Facebook Post connector for this account.') . ''; + . $a->get_baseurl() . '/fbpost/' . $a->user['nickname'] . '&scope=publish_stream,manage_pages,offline_access">' . t('Install Facebook Post connector for this account.') . ''; $o .= '
'; } @@ -214,16 +221,44 @@ function fbpost_content(&$a) { $o .= '
'; $o .= '' . t('Re-authenticate [This is necessary whenever your Facebook password is changed.]') . ''; + . $a->get_baseurl() . '/fbpost/' . $a->user['nickname'] . '&scope=publish_stream,manage_pages,offline_access">' . t('Re-authenticate [This is necessary whenever your Facebook password is changed.]') . ''; $o .= '
'; - + $o .= '
'; $o .= '
'; $post_by_default = get_pconfig(local_user(),'facebook','post_by_default'); $checked = (($post_by_default) ? ' checked="checked" ' : ''); $o .= '' . ' ' . t('Post to Facebook by default') . EOL; - $o .= '
'; + $suppress_view_on_friendica = get_pconfig(local_user(),'facebook','suppress_view_on_friendica'); + $checked = (($suppress_view_on_friendica) ? ' checked="checked" ' : ''); + $o .= '' . ' ' . t('Suppress "View on friendica"') . EOL; + + // List all pages + $post_to_page = get_pconfig(local_user(),'facebook','post_to_page'); + $page_access_token = get_pconfig(local_user(),'facebook','page_access_token'); + $fb_token = get_pconfig($a->user['uid'],'facebook','access_token'); + $url = 'https://graph.facebook.com/me/accounts'; + $x = file_get_contents($url."?access_token=".$fb_token); + $accounts = json_decode($x); + + $o .= t("Post to page:").""; + + $o .= '

'; + } return $o; @@ -353,10 +388,10 @@ function fbpost_post_hook(&$a,&$b) { return; // only accept comments from the item owner. Other contacts are unknown to FB. - + if(! link_compare($b['author-link'], $a->get_baseurl() . '/profile/' . $u[0]['nickname'])) return; - + logger('facebook reply id=' . $reply); } @@ -408,7 +443,7 @@ function fbpost_post_hook(&$a,&$b) { } if($b['verb'] == ACTIVITY_LIKE) - $likes = true; + $likes = true; $appid = get_config('facebook', 'appid' ); @@ -421,9 +456,9 @@ function fbpost_post_hook(&$a,&$b) { $fb_token = get_pconfig($b['uid'],'facebook','access_token'); - // post to facebook if it's a public post and we've ticked the 'post to Facebook' box, + // post to facebook if it's a public post and we've ticked the 'post to Facebook' box, // or it's a private message with facebook participants - // or it's a reply or likes action to an existing facebook post + // or it's a reply or likes action to an existing facebook post if($fb_token && ($toplevel || $b['private'] || $reply)) { logger('facebook: able to post'); @@ -602,11 +637,18 @@ function fbpost_post_hook(&$a,&$b) { } + $post_to_page = get_pconfig($b['uid'],'facebook','post_to_page'); + $page_access_token = get_pconfig($b['uid'],'facebook','page_access_token'); + if ((intval($post_to_page) != 0) and ($page_access_token != "")) + $target = $post_to_page; + else + $target = "me"; + if($reply) { $url = 'https://graph.facebook.com/' . $reply . '/' . (($likes) ? 'likes' : 'comments'); - } else if (($link != "") or ($image != "") or ($b['title'] == '') or (strlen($msg) < 500)) { - $url = 'https://graph.facebook.com/me/feed'; - if($b['plink']) + } else if (($link != "") or ($image != "") or ($b['title'] == '') or (strlen($msg) < 500) or ($target != "me")) { + $url = 'https://graph.facebook.com/'.$target.'/feed'; + if (!get_pconfig($b['uid'],'facebook','suppress_view_on_friendica') and $b['plink']) $postvars['actions'] = '{"name": "' . t('View on Friendica') . '", "link": "' . $b['plink'] . '"}'; } else { // if its only a message and a subject and the message is larger than 500 characters then post it as note @@ -618,6 +660,10 @@ function fbpost_post_hook(&$a,&$b) { $url = 'https://graph.facebook.com/me/notes'; } + // Post to page? + if (!$reply and $target != "me") + $postvars['access_token'] = $page_access_token; + logger('facebook: post to ' . $url); logger('facebook: postvars: ' . print_r($postvars,true)); diff --git a/statusnet/statusnet.php b/statusnet/statusnet.php index c8330a7e..bdbb4d4a 100755 --- a/statusnet/statusnet.php +++ b/statusnet/statusnet.php @@ -505,7 +505,7 @@ function statusnet_shortenmsg($b, $max_char) { while (strpos($msg, " ") !== false) $msg = str_replace(" ", " ", $msg); - return(trim($msg." ".$msglink)); + return(array("msg"=>trim($msg." ".$msglink), "image"=>$image)); } function statusnet_post_hook(&$a,&$b) { @@ -612,14 +612,24 @@ function statusnet_post_hook(&$a,&$b) { } $msg = trim($msg); - } else - $msg = statusnet_shortenmsg($b, $max_char); + $postdata = array('status' => $msg); + } else { + $msgarr = statusnet_shortenmsg($b, $max_char); + $msg = $msgarr["msg"]; + $image = $msgarr["image"]; + if ($image != "") { + $imagedata = file_get_contents($image); + $postdata = array("status"=>$msg, "media"=>$imagedata); + } else + $postdata = array("status"=>$msg); + } // and now dent it :-) if(strlen($msg)) { - $result = $dent->post('statuses/update', array('status' => $msg)); + //$result = $dent->post('statuses/update', array('status' => $msg)); + $result = $dent->post('statuses/update', $postdata); logger('statusnet_post send, result: ' . print_r($result, true). - "\nmessage: ".$msg, LOGGER_DEBUG."\nOriginal post: ".print_r($b)); + "\nmessage: ".$msg, LOGGER_DEBUG."\nOriginal post: ".print_r($b)."\nPost Data: ".print_r($postdata)); if ($result->error) { logger('Send to StatusNet failed: "' . $result->error . '"'); } From 50c33d8dc25f19c10cf0f1cf15ed6daa0b76055f Mon Sep 17 00:00:00 2001 From: Michael Vogel Date: Thu, 22 Nov 2012 03:31:43 +0100 Subject: [PATCH 2/6] fbpost: Posting to groups enabled twitter/statusnet: Bug fixed where messages were shortened too much. --- fbpost/fbpost.php | 20 ++++++++++++++++---- statusnet/statusnet.php | 2 +- twitter/twitter.php | 2 +- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/fbpost/fbpost.php b/fbpost/fbpost.php index 01311320..8c45d004 100644 --- a/fbpost/fbpost.php +++ b/fbpost/fbpost.php @@ -209,7 +209,7 @@ function fbpost_content(&$a) { $o .= '

'; $o .= '' . t('Install Facebook Post connector for this account.') . ''; + . $a->get_baseurl() . '/fbpost/' . $a->user['nickname'] . '&scope=publish_stream,manage_pages,user_groups,friends_groups,offline_access">' . t('Install Facebook Post connector for this account.') . ''; $o .= '
'; } @@ -221,7 +221,7 @@ function fbpost_content(&$a) { $o .= '
'; $o .= '' . t('Re-authenticate [This is necessary whenever your Facebook password is changed.]') . ''; + . $a->get_baseurl() . '/fbpost/' . $a->user['nickname'] . '&scope=publish_stream,manage_pages,user_groups,friends_groups,offline_access">' . t('Re-authenticate [This is necessary whenever your Facebook password is changed.]') . ''; $o .= '
'; $o .= '
'; @@ -242,7 +242,7 @@ function fbpost_content(&$a) { $x = file_get_contents($url."?access_token=".$fb_token); $accounts = json_decode($x); - $o .= t("Post to page:").""; if (intval($post_to_page) == 0) $o .= ""; else @@ -255,6 +255,18 @@ function fbpost_content(&$a) { else $o .= ""; } + + $url = 'https://graph.facebook.com/me/groups'; + $x = file_get_contents($url."?access_token=".$fb_token); + $groups = json_decode($x); + + foreach($groups->data as $group) { + if ($post_to_page == $group->id) + $o .= ""; + else + $o .= ""; + } + $o .= ""; $o .= '

'; @@ -661,7 +673,7 @@ function fbpost_post_hook(&$a,&$b) { } // Post to page? - if (!$reply and $target != "me") + if (!$reply and ($target != "me") and $page_access_token) $postvars['access_token'] = $page_access_token; logger('facebook: post to ' . $url); diff --git a/statusnet/statusnet.php b/statusnet/statusnet.php index bdbb4d4a..3bbe4171 100755 --- a/statusnet/statusnet.php +++ b/statusnet/statusnet.php @@ -495,7 +495,7 @@ function statusnet_shortenmsg($b, $max_char) { $msg = substr($msg, 0, -1); $pos = strrpos($msg, "\n"); if ($pos > 0) - $msg = substr($msg, 0, $pos-1); + $msg = substr($msg, 0, $pos); else if ($lastchar != "\n") $msg = substr($msg, 0, -3)."..."; } diff --git a/twitter/twitter.php b/twitter/twitter.php index 3fcaa1de..6a93d9f1 100755 --- a/twitter/twitter.php +++ b/twitter/twitter.php @@ -354,7 +354,7 @@ function twitter_shortenmsg($b) { $msg = substr($msg, 0, -1); $pos = strrpos($msg, "\n"); if ($pos > 0) - $msg = substr($msg, 0, $pos-1); + $msg = substr($msg, 0, $pos); else if ($lastchar != "\n") $msg = substr($msg, 0, -3)."..."; } From de8a7f88ce150852534b1f3a9531b4328df1c613 Mon Sep 17 00:00:00 2001 From: Michael Vogel Date: Thu, 22 Nov 2012 15:29:20 +0100 Subject: [PATCH 3/6] Facebook: Posts that only contain images without links are now posted as images Statusnet: Trying to post images - but it doesn't work right now --- fbpost/fbpost.php | 22 ++++++++++++++++------ statusnet/statusnet.php | 7 ++++++- 2 files changed, 22 insertions(+), 7 deletions(-) diff --git a/fbpost/fbpost.php b/fbpost/fbpost.php index 8c45d004..cbe512e1 100644 --- a/fbpost/fbpost.php +++ b/fbpost/fbpost.php @@ -209,7 +209,7 @@ function fbpost_content(&$a) { $o .= '
'; $o .= '' . t('Install Facebook Post connector for this account.') . ''; + . $a->get_baseurl() . '/fbpost/' . $a->user['nickname'] . '&scope=publish_stream,manage_pages,photo_upload,user_groups,offline_access">' . t('Install Facebook Post connector for this account.') . ''; $o .= '
'; } @@ -221,7 +221,7 @@ function fbpost_content(&$a) { $o .= '
'; $o .= '' . t('Re-authenticate [This is necessary whenever your Facebook password is changed.]') . ''; + . $a->get_baseurl() . '/fbpost/' . $a->user['nickname'] . '&scope=publish_stream,manage_pages,photo_upload,user_groups,offline_access">' . t('Re-authenticate [This is necessary whenever your Facebook password is changed.]') . ''; $o .= '
'; $o .= '
'; @@ -658,6 +658,16 @@ function fbpost_post_hook(&$a,&$b) { if($reply) { $url = 'https://graph.facebook.com/' . $reply . '/' . (($likes) ? 'likes' : 'comments'); + } else if (($link == "") and ($image != "")) { + // If it is only an image without a page link then post this image as a photo + $postvars = array( + 'access_token' => $fb_token, + 'url' => $image, + ); + if ($msg != $image) + $postvars['message'] = $msg; + + $url = 'https://graph.facebook.com/'.$target.'/photos'; } else if (($link != "") or ($image != "") or ($b['title'] == '') or (strlen($msg) < 500) or ($target != "me")) { $url = 'https://graph.facebook.com/'.$target.'/feed'; if (!get_pconfig($b['uid'],'facebook','suppress_view_on_friendica') and $b['plink']) @@ -700,14 +710,14 @@ function fbpost_post_hook(&$a,&$b) { add_to_queue($a->contact,NETWORK_FACEBOOK,$s); notice( t('Facebook post failed. Queued for retry.') . EOL); } - + if (isset($retj->error) && $retj->error->type == "OAuthException" && $retj->error->code == 190) { logger('Facebook session has expired due to changed password.', LOGGER_DEBUG); - + $last_notification = get_pconfig($b['uid'], 'facebook', 'session_expired_mailsent'); if (!$last_notification || $last_notification < (time() - FACEBOOK_SESSION_ERR_NOTIFICATION_INTERVAL)) { require_once('include/enotify.php'); - + $r = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1", intval($b['uid']) ); notification(array( 'uid' => $b['uid'], @@ -720,7 +730,7 @@ function fbpost_post_hook(&$a,&$b) { 'source_link' => $a->config["system"]["url"], 'source_photo' => $a->config["system"]["url"] . '/images/person-80.jpg', )); - + set_pconfig($b['uid'], 'facebook', 'session_expired_mailsent', time()); } else logger('Facebook: No notification, as the last one was sent on ' . $last_notification, LOGGER_DEBUG); } diff --git a/statusnet/statusnet.php b/statusnet/statusnet.php index 3bbe4171..9bbe4dcd 100755 --- a/statusnet/statusnet.php +++ b/statusnet/statusnet.php @@ -538,6 +538,7 @@ function statusnet_post_hook(&$a,&$b) { // information during shortening of potential links but do not // shorten all the links in a 200000 character long essay. + $tempfile = ""; $intelligent_shortening = get_config('statusnet','intelligent_shortening'); if (!$intelligent_shortening) { if (! $b['title']=='') { @@ -619,7 +620,9 @@ function statusnet_post_hook(&$a,&$b) { $image = $msgarr["image"]; if ($image != "") { $imagedata = file_get_contents($image); - $postdata = array("status"=>$msg, "media"=>$imagedata); + $tempfile = tempnam("", "upload"); + file_put_contents($tempfile, $imagedata); + $postdata = array("status"=>$msg, "media"=>"@".$tempfile); } else $postdata = array("status"=>$msg); } @@ -634,6 +637,8 @@ function statusnet_post_hook(&$a,&$b) { logger('Send to StatusNet failed: "' . $result->error . '"'); } } + if ($tempfile != "") + unlink($tempfile); } } From f9c2e64c8f23a0c2cd74c8435d4f69ae1c723a14 Mon Sep 17 00:00:00 2001 From: Michael Vogel Date: Thu, 22 Nov 2012 16:10:47 +0100 Subject: [PATCH 4/6] fbpost: videos are now posted as links --- fbpost/fbpost.php | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/fbpost/fbpost.php b/fbpost/fbpost.php index cbe512e1..c564269e 100644 --- a/fbpost/fbpost.php +++ b/fbpost/fbpost.php @@ -615,10 +615,11 @@ function fbpost_post_hook(&$a,&$b) { logger('Facebook post: msg=' . $msg, LOGGER_DATA); + $video = ""; + if($likes) { $postvars = array('access_token' => $fb_token); - } - else { + } else { // message, picture, link, name, caption, description, source, place, tags $postvars = array( 'access_token' => $fb_token, @@ -630,9 +631,8 @@ function fbpost_post_hook(&$a,&$b) { if(trim($link) != "") { $postvars['link'] = $link; - // The following doesn't work - why? if ((stristr($link,'youtube')) || (stristr($link,'youtu.be')) || (stristr($link,'vimeo'))) { - $postvars['source'] = $link; + $video = $link; } } if(trim($linkname) != "") @@ -658,6 +658,16 @@ function fbpost_post_hook(&$a,&$b) { if($reply) { $url = 'https://graph.facebook.com/' . $reply . '/' . (($likes) ? 'likes' : 'comments'); + } else if (($video != "")) { + // If it is a link to a video then post it as a link + $postvars = array( + 'access_token' => $fb_token, + 'link' => $video, + ); + if ($msg != $video) + $postvars['message'] = $msg; + + $url = 'https://graph.facebook.com/'.$target.'/links'; } else if (($link == "") and ($image != "")) { // If it is only an image without a page link then post this image as a photo $postvars = array( From 23ca42a056878c888324979056a16f0a8e190efc Mon Sep 17 00:00:00 2001 From: Michael Vogel Date: Thu, 22 Nov 2012 23:24:05 +0100 Subject: [PATCH 5/6] fbpost: Improve posts with videos (they are now posted as links). Textconversion for repeated posts changed. --- fbpost/fbpost.php | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/fbpost/fbpost.php b/fbpost/fbpost.php index c564269e..9bf4a759 100644 --- a/fbpost/fbpost.php +++ b/fbpost/fbpost.php @@ -553,6 +553,14 @@ function fbpost_post_hook(&$a,&$b) { $body = $body1.$body2; } + // Convert recycle signs + // recycle 1 + $recycle = html_entity_decode("♲ ", ENT_QUOTES, 'UTF-8'); + $body = preg_replace( '/'.$recycle.'\[url\=(\w+.*?)\](\w+.*?)\[\/url\]/i', "\n$2:[quote]", $body)."[/quote]"; + // recycle 2 (Test) + $recycle = html_entity_decode("◌ ", ENT_QUOTES, 'UTF-8'); + $body = preg_replace( '/'.$recycle.'\[url\=(\w+.*?)\](\w+.*?)\[\/url\]/i', "\n$2:[quote]", $body)."[/quote]"; + // At first convert the text to html $html = bbcode($body, false, false); @@ -658,11 +666,14 @@ function fbpost_post_hook(&$a,&$b) { if($reply) { $url = 'https://graph.facebook.com/' . $reply . '/' . (($likes) ? 'likes' : 'comments'); - } else if (($video != "")) { - // If it is a link to a video then post it as a link + } else if (($video != "") or (($image == "") and ($link != ""))) { + // If it is a link to a video or a link without a preview picture then post it as a link + if ($video != "") + $link = $video; + $postvars = array( 'access_token' => $fb_token, - 'link' => $video, + 'link' => $link, ); if ($msg != $video) $postvars['message'] = $msg; @@ -678,7 +689,7 @@ function fbpost_post_hook(&$a,&$b) { $postvars['message'] = $msg; $url = 'https://graph.facebook.com/'.$target.'/photos'; - } else if (($link != "") or ($image != "") or ($b['title'] == '') or (strlen($msg) < 500) or ($target != "me")) { + } else if (($link != "") or ($image != "") or ($b['title'] == '') or (strlen($msg) < 500)) { $url = 'https://graph.facebook.com/'.$target.'/feed'; if (!get_pconfig($b['uid'],'facebook','suppress_view_on_friendica') and $b['plink']) $postvars['actions'] = '{"name": "' . t('View on Friendica') . '", "link": "' . $b['plink'] . '"}'; @@ -689,7 +700,7 @@ function fbpost_post_hook(&$a,&$b) { 'message' => bbcode($b['body'], false, false), 'subject' => $b['title'], ); - $url = 'https://graph.facebook.com/me/notes'; + $url = 'https://graph.facebook.com/'.$target.'/notes'; } // Post to page? From b3fa9eb34120bc7af6a873901be2875fdd50e446 Mon Sep 17 00:00:00 2001 From: Michael Vogel Date: Fri, 23 Nov 2012 12:15:40 +0100 Subject: [PATCH 6/6] fbpost: New behaviour when a picture link is converted. New behaviour for repeated messages. --- fbpost/fbpost.php | 29 +++++++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/fbpost/fbpost.php b/fbpost/fbpost.php index 9bf4a759..0bafd81e 100644 --- a/fbpost/fbpost.php +++ b/fbpost/fbpost.php @@ -554,18 +554,33 @@ function fbpost_post_hook(&$a,&$b) { } // Convert recycle signs + $body = str_replace("\t", " ", $body); // recycle 1 $recycle = html_entity_decode("♲ ", ENT_QUOTES, 'UTF-8'); - $body = preg_replace( '/'.$recycle.'\[url\=(\w+.*?)\](\w+.*?)\[\/url\]/i', "\n$2:[quote]", $body)."[/quote]"; + $body = preg_replace( '/'.$recycle.'\[url\=(\w+.*?)\](\w+.*?)\[\/url\]/i', "\n\t$2:\t", $body); // recycle 2 (Test) $recycle = html_entity_decode("◌ ", ENT_QUOTES, 'UTF-8'); - $body = preg_replace( '/'.$recycle.'\[url\=(\w+.*?)\](\w+.*?)\[\/url\]/i', "\n$2:[quote]", $body)."[/quote]"; + $body = preg_replace( '/'.$recycle.'\[url\=(\w+.*?)\](\w+.*?)\[\/url\]/i', "\n\t$2:\t", $body); + + $bodyparts = explode("\t", $body); + // Doesn't help with multiple repeats - the problem has to be solved later + if (sizeof($bodyparts) == 3) { + if (trim($bodyparts[0]) == "") + $body = trim($bodyparts[2]); + else if (trim($bodyparts[2]) == "") + $body = trim($bodyparts[0]); + else + $body = trim($bodyparts[0])."\n\n".trim($bodyparts[1])."[quote]".trim($bodyparts[2])."[/quote]"; + //$body = trim(str_replace(array(":\t", "\t"), array(":[quote]", ""), $body))."[/quote]"; + } else + $body = str_replace("\t", "", $body); // At first convert the text to html $html = bbcode($body, false, false); // Then convert it to plain text $msg = trim($b['title']." \n\n".html2plain($html, 0, true)); + $msg = str_replace("\n«", "«", $msg); // Quickfix - the original problem lies in the html2plain conversion $msg = html_entity_decode($msg,ENT_QUOTES,'UTF-8'); // Removing multiple newlines @@ -629,13 +644,19 @@ function fbpost_post_hook(&$a,&$b) { $postvars = array('access_token' => $fb_token); } else { // message, picture, link, name, caption, description, source, place, tags + if(trim($link) != "") + if (@exif_imagetype($link) != 0) { + $image = $link; + $link = ""; + } + $postvars = array( 'access_token' => $fb_token, 'message' => $msg ); - if(trim($image) != "") { + if(trim($image) != "") $postvars['picture'] = $image; - } + if(trim($link) != "") { $postvars['link'] = $link;