From e46bff23d5497afe239c6e4c1f3c828d03b27ab6 Mon Sep 17 00:00:00 2001
From: Hypolite Petovan <hypolite@mrpetovan.com>
Date: Fri, 7 Jan 2022 12:34:28 +0100
Subject: [PATCH] [twitter] Abort follow process on API call failure

- Prevents users without a connected Twitter account from visibly following a Twitter contact
---
 twitter/twitter.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/twitter/twitter.php b/twitter/twitter.php
index 33af5663..d9f1310a 100644
--- a/twitter/twitter.php
+++ b/twitter/twitter.php
@@ -157,7 +157,10 @@ function twitter_follow(App $a, array &$contact)
 
 	$uid = $a->getLoggedInUserId();
 
-	twitter_api_contact('friendships/create', ['network' => Protocol::TWITTER, 'nick' => $nickname], $uid);
+	if (!twitter_api_contact('friendships/create', ['network' => Protocol::TWITTER, 'nick' => $nickname], $uid)) {
+		$contact = null;
+		return;
+	}
 
 	$user = twitter_fetchuser($nickname);