friendica/friendica-addons
1
0
Fork 0
mirror of https://git.friendi.ca/friendica/friendica-addons.git synced 2025-07-09 18:08:49 +00:00
Code Issues Releases Wiki Activity

Avoid warnings in addons (#639)

Browse source 
* Avoid warnings in addons

* And some warnings removed

* And more ...

* And some more ...

* Added comment

* And again ...

* And again ...

* Partly reworked "newmemberwidget"

* And more warnings ...

* The next round
This commit is contained in:
Michael Vogel 2018-07-10 14:30:23 +02:00 • committed by Hypolite Petovan
parent 9ec2b9390b
commit 475299e642
12 changed files with 102 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

42
twitter/twitter.php
View file

@ -422,6 +422,7 @@ function twitter_action(App $a, $uid, $pid, $action)
switch ($action) {
case "delete":
// To-Do: $result = $connection->post('statuses/destroy', $post);
$result = [];
break;
case "like":
$result = $connection->post('favorites/create', $post);
@ -429,6 +430,9 @@ function twitter_action(App $a, $uid, $pid, $action)
case "unlike":
$result = $connection->post('favorites/destroy', $post);
break;
default:
logger('Unhandled action ' . $action, LOGGER_DEBUG);
$result = [];
}
logger("twitter_action '" . $action . "' send, result: " . print_r($result, true), LOGGER_DEBUG);
}
@ -799,7 +803,7 @@ function twitter_do_mirrorpost(App $a, $uid, $post)
// $datarray['object'] = json_encode($post); // Activate for debugging
$datarray["title"] = "";
if (is_object($post->retweeted_status)) {
if (!empty($post->retweeted_status)) {
// We don't support nested shares, so we mustn't show quotes as shares on retweets
$item = twitter_createpost($a, $uid, $post->retweeted_status, ['id' => 0], false, false, true);
@ -1131,6 +1135,10 @@ function twitter_expand_entities(App $a, $body, $item, $picture)
$oembed_data = OEmbed::fetchURL($expanded_url);
if (empty($oembed_data) || empty($oembed_data->type)) {
continue;
}
// Quickfix: Workaround for URL with "[" and "]" in it
if (strpos($expanded_url, "[") || strpos($expanded_url, "]")) {
$expanded_url = $url->url;
@ -1254,7 +1262,7 @@ function twitter_expand_entities(App $a, $body, $item, $picture)
function twitter_media_entities($post, &$postarray)
{
// There are no media entities? So we quit.
if (!is_array($post->extended_entities->media)) {
if (empty($post->extended_entities->media)) {
return "";
}
@ -1274,6 +1282,9 @@ function twitter_media_entities($post, &$postarray)
// This is a pure media post, first search for all media urls
$media = [];
foreach ($post->extended_entities->media AS $medium) {
if (!isset($media[$medium->url])) {
$media[$medium->url] = '';
}
switch ($medium->type) {
case 'photo':
$media[$medium->url] .= "\n[img]" . $medium->media_url_https . "[/img]";
@ -1396,6 +1407,9 @@ function twitter_createpost(App $a, $uid, $post, $self, $create_user, $only_exis
if ($post->user->protected) {
$postarray['private'] = 1;
$postarray['allow_cid'] = '<' . $self['id'] . '>';
} else {
$postarray['private'] = 0;
$postarray['allow_cid'] = '';
}
if (is_string($post->full_text)) {
@ -1420,22 +1434,22 @@ function twitter_createpost(App $a, $uid, $post, $self, $create_user, $only_exis
$statustext = $converted["plain"];
if (is_string($post->place->name)) {
if (!empty($post->place->name)) {
$postarray["location"] = $post->place->name;
}
if (is_string($post->place->full_name)) {
if (!empty($post->place->full_name)) {
$postarray["location"] = $post->place->full_name;
}
if (is_array($post->geo->coordinates)) {
if (!empty($post->geo->coordinates)) {
$postarray["coord"] = $post->geo->coordinates[0] . " " . $post->geo->coordinates[1];
}
if (is_array($post->coordinates->coordinates)) {
if (!empty($post->coordinates->coordinates)) {
$postarray["coord"] = $post->coordinates->coordinates[1] . " " . $post->coordinates->coordinates[0];
}
if (is_object($post->retweeted_status)) {
if (!empty($post->retweeted_status)) {
$retweet = twitter_createpost($a, $uid, $post->retweeted_status, $self, false, false, $noquote);
$retweet['object'] = $postarray['object'];
//$retweet['object'] = $postarray['object']; // Activate for debugging
$retweet['private'] = $postarray['private'];
$retweet['allow_cid'] = $postarray['allow_cid'];
$retweet['contact-id'] = $postarray['contact-id'];
@ -1446,7 +1460,7 @@ function twitter_createpost(App $a, $uid, $post, $self, $create_user, $only_exis
$postarray = $retweet;
}
if (is_object($post->quoted_status) && !$noquote) {
if (!empty($post->quoted_status) && !$noquote) {
$quoted = twitter_createpost($a, $uid, $post->quoted_status, $self, false, false, true);
$postarray['body'] = $statustext;
@ -1498,20 +1512,16 @@ function twitter_fetchparentposts(App $a, $uid, $post, TwitterOAuth $connection,
$posts = array_reverse($posts);
if (count($posts)) {
if (!empty($posts)) {
foreach ($posts as $post) {
$postarray = twitter_createpost($a, $uid, $post, $self, false, false, false);
if (trim($postarray['body']) == "") {
if (empty($postarray['body'])) {
continue;
}
$item = Item::insert($postarray);
if ($notify) {
$item = $notify;
}
$postarray["id"] = $item;
logger('twitter_fetchparentpost: User ' . $self["nick"] . ' posted parent timeline item ' . $item);
@ -1629,7 +1639,7 @@ function twitter_fetchhometimeline(App $a, $uid)
$postarray = twitter_createpost($a, $uid, $post, $self, $create_user, true, false);
if (trim($postarray['body']) == "") {
if (empty($postarray['body']) || trim($postarray['body']) == "") {
continue;
}