From 2b5764c132bb02390d8a417bc80e0fb28f83df07 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakobus=20Sch=C3=BCrz?= <jakobus.schuerz@home.arpa>
Date: Wed, 15 Jan 2025 10:42:08 +0100
Subject: [PATCH] rework saml addon

fix #1587
remove css-side hiding of elements, which was broken.
remove them or make them readonly via javascript
---
 saml/saml.css | 1 -
 saml/saml.php | 9 ++++-----
 2 files changed, 4 insertions(+), 6 deletions(-)
 delete mode 100644 saml/saml.css

diff --git a/saml/saml.css b/saml/saml.css
deleted file mode 100644
index 087633cd..00000000
--- a/saml/saml.css
+++ /dev/null
@@ -1 +0,0 @@
-#settings-form > div:first-of-type, #settings-form > h2:first-of-type, #wrapper_mpassword, #wrapper_email { display: none !important; }
diff --git a/saml/saml.php b/saml/saml.php
index 9f065355..f3dd1774 100755
--- a/saml/saml.php
+++ b/saml/saml.php
@@ -75,11 +75,6 @@ function saml_install()
 	Hook::register('footer', __FILE__, 'saml_footer');
 }
 
-function saml_head(string &$body)
-{
-	DI::page()->registerStylesheet(__DIR__ . '/saml.css');
-}
-
 function saml_footer(string &$body)
 {
 	$fragment = addslashes(BBCode::convertForUriId(User::getSystemUriId(), DI::config()->get('saml', 'settings_statement')));
@@ -87,6 +82,10 @@ function saml_footer(string &$body)
 <script>
 var target=$("#settings-nickname-desc");
 if (target.length) { target.append("<p>$fragment</p>"); }
+document.getElementById('id_email').setAttribute('readonly', 'readonly');
+document.getElementById('password-settings').remove();
+document.getElementById('password-settings-collapse').remove();
+document.getElementById('id_mpassword_wrapper').remove();
 </script>
 EOL;
 }